search

Skynet2-0 / Skynet2.0

GNU General Public License v3.0
2 stars 2 forks source link

Addtribler #31

Closed i-am-xhy closed 8 years ago

i-am-xhy commented 8 years ago

adds exitnode with no working multichain

StefanBoodt commented 8 years ago

Why did you destroy the fix on the addrgen with this PR? This should not be merged this way. Nice that tribler submodule is gone though.

niels: what fix on the addrgen are you talking about? do you mean that it is now named addrgen2 instead of addrgen-master? because that is just the identifier git itself uses, i fail to see why the specific name would matter

StefanBoodt commented 8 years ago

In addition why is addrgen.sh changed. I do not see why this change was made.

niels: this change was done because it originally did not work in the branch when i split it from master. in the meantime it was also fixed in master therefore there are 2 different codes. i have changed it to conform to the master branch approach

StefanBoodt commented 8 years ago

I do not think that Exitnode.py can be refactored within 1 year of work for 1 person.

Niels: actually i'm going to leave it in, so we can do it if sig wants it improved.

StefanBoodt commented 8 years ago

This pull request fixes #32 but I wonder how long #15 will stay fixed.

Niels: while that is a perfectly valid point, since the tribler team stormed in yesterday declared they where going to change tribler -but not how- and stormed out again, implying they wouldn't support multichain in their new version. I have yet to get any confirmation as to what will change other than that it involves twitsted in some way