search

Skynet2-0 / Skynet2.0

GNU General Public License v3.0
2 stars 2 forks source link

wallet refactor bug #42

Closed i-am-xhy closed 8 years ago

i-am-xhy commented 8 years ago

the recent refactor left a bug in wallet for ommited self in __ignore_pasword_prompt

i-am-xhy commented 8 years ago

fixed in most recent version of prototype2, will close issue once that branch is in master

StefanBoodt commented 8 years ago

It was already fixed in #43 as stated before. I was assigned this as well. The way you close issues is by writing fixes/solves #issuenumber. Then the issue closes when the commit reaches master. This way you get a nice history of bugs and problems, and it is clear to development teams how and where the issue is fixed. This prevents redundant fixes when the issue reappears.

It also makes it very clear that the issue is referenced by adding the line to the issue that is standing just above your comment.