SkynetLabs / ansible-playbooks

SkynetLabs Ansible Playbooks
6 stars 5 forks source link

Add run shell command playbook #325

Closed firyx closed 2 years ago

firyx commented 2 years ago

PULL REQUEST

Overview

Adding a playbook to run ad-hoc shell commands against the portals.

Example for Visual Changes

Checklist

Issues Closed

linear[bot] commented 2 years ago

SKY-943 Create run shell command playbook

firyx commented 2 years ago

Is there a way we can combine this with the docker commands? Very similar, potentially the same, if the docker command variable was named better. My bad grimacing

Is there a way we can combine this with the docker commands? Very similar, potentially the same, if the docker command variable was named better. My bad grimacing

Refactored to unite docker/shell commands. There are now 2 distinct playbooks to run shell commands - safer with and less safer without taking portals out of LB. Described in updated Readme.

firyx commented 2 years ago

@kwypchlo Once this is merged and changes are pulled, we should update docker_commands to shell_commands in deploy-2022-... configs.

firyx commented 2 years ago

Backwards compatibility (no change to existing configs is needed):

kwypchlo commented 2 years ago

Backwards compatibility (no change to existing configs is needed):

  • at least one of: older docker_commands or newer shell_commands must be defined
  • when both are defined: Ansible adds those 2 lists and runs all commands

hold up, what do you mean at least one has to be defined? defining additional commands should be really optional right?

firyx commented 2 years ago

Backwards compatibility (no change to existing configs is needed):

  • at least one of: older docker_commands or newer shell_commands must be defined
  • when both are defined: Ansible adds those 2 lists and runs all commands

hold up, what do you mean at least one has to be defined? defining additional commands should be really optional right?

My bad (incomplete) wording:

kwypchlo commented 2 years ago

not on a current roadmap