search

SkynetLabs / python-skynet

Library for integrating Skynet with Python applications
MIT License
15 stars 8 forks source link

add Skynet Api Key support #9

Closed dghelm closed 2 years ago

dghelm commented 2 years ago

PULL REQUEST

Overview

Adds custom_opt for adding Skynet-Api-Key

Note: I tried modifying the tests, but something about my environment is causing various warnings and mocks to fail. Fileportal.org seemed to break tests as well without an API Key.

Issues Closed

Closes #8

mrcnski commented 2 years ago

Note: I tried modifying the tests, but something about my environment is causing various warnings and mocks to fail. Fileportal.org seemed to break tests as well without an API Key.

@dghelm You were missing a default value for the new option in order to make this work. Whenever I add a new option, in any SDK, I always grep for an existing option in the code to see where and how it's implemented, and add the new option in the same places. I also look for a test for the existing option, and copy or update it for the new option.