SkynetLabs / skynet-accounts

Other

8 stars 5 forks source link

Use go 1.18 for the JSWKS generator. #220

Closed ro-tex closed 2 years ago

ro-tex commented 2 years ago

PULL REQUEST

Overview

Karol reported that while running make docker-generate on xyz he encountered

/go/pkg/mod/github.com/ory/x@v0.0.368/jsonx/get.go:19:13: f.IsExported undefined (type reflect.StructField has no field or method IsExported)
The command '/bin/sh -c go get github.com/ory/hydra/jwk' returned a non-zero code: 2
make: *** [Makefile:165: docker-generate] Error 2

and I confirmed that locally. Upgrading the go image to 1.18 fixes the incompatibility.

Example for Visual Changes

Checklist

[ ] All git commits are signed. (REQUIRED)
[ ] All new methods or updated methods have clear docstrings.
[ ] Testing added or updated for new methods.
[ ] Verified if any changes impact the WebPortal Health Checks.
[ ] Appropriate documentation updated.
[ ] Changelog file created.

Issues Closed