search

SkynetLabs / skynet-kernel

MIT License
27 stars 4 forks source link

Skylink and Registry Files #253

Closed DavidVorick closed 2 years ago

DavidVorick commented 2 years ago

Moving more files over. This is still mostly just adhering to the Skynet API, most of these functions don't have the ability to be adjusted beyond bikeshedding the implementation.

DavidVorick commented 2 years ago

Merging this despite a few outstanding discussions as it's stalling out development in other places - libskynet needs to keep growing as the kernel gets support for websockets, etc

DavidVorick commented 2 years ago

The vast majority of the discussions were addressed, and looking at the original code (no jest, lots of implementation changes, etc) you can see that a great number of the comments were accepted and implemented. I know there's still a lot of difference between us in how we think the code should look, but the reviews here made a large impact on the overall shape of the code