search

SkynetLabs / webportal-nginx

MIT License
1 stars 2 forks source link

NGINX Lua comments #3

Open MSevey opened 3 years ago

MSevey commented 3 years ago

Can be a follow up, but does NGINX and lua allow for comments? Because if so we NEED to be adding them so that others can better understand what is happening here.

Reading this with no context makes me think you are setting the same skylink as the v1 and v2 skylink which intuitively doesn't make sense.

_Originally posted by @MSevey in https://github.com/SkynetLabs/skynet-webportal/pull/1223#discussion_r736469544_

MSevey commented 3 years ago

Are we overwriting the content type here or we're only setting it if it's not set? If we're overwriting it that might not be great.

_Originally posted by @ro-tex in https://github.com/SkynetLabs/skynet-webportal/pull/1223#discussion_r736659668_