Fix subtraction logic error on HourMinute

Skyost / FlutterWeekView

Displays a highly customizable week view (or day view) which is able to display events, to be scrolled, to be zoomed-in & out and a lot more !

https://pub.dev/packages/flutter_week_view

MIT License

208 stars 89 forks source link

Fix subtraction logic error on HourMinute #61

Closed Yoropiata closed 3 years ago

Yoropiata commented 3 years ago

Subtraction did not take account for subtractions where minutes of the subtracting HourMinute does not exceed that of the source HourDate. This code should fix that issue.

Example: HourMinute (hour: 0, minute: 36).subtract(HourMinute (hour: 1) Used to return HourMinute (hour: 0, minute: 36) Now returns HourMinute (hour: 0, minute: 0) aka. HourMinute.ZERO

Skyost commented 3 years ago

Do you have tested the whole plugin after that change ?