search

Skyost / RateMyApp

This plugin allows to kindly ask users to rate your app if custom conditions are met (eg. install time, number of launches, etc...).
https://pub.dev/packages/rate_my_app
MIT License
265 stars 106 forks source link

Extra permissions added to Android manifest because of this plugin #137

Closed bhumkong closed 2 months ago

bhumkong commented 1 year ago

Describe the bug Changes to build.gradle file in version 2.0.0 of this plugin cause extra permissions appear in Android app manifest on build when this package is installed. It's READ_PHONE_STATE and WRITE_EXTERNAL_STORAGE permissions. manifest-merger-debug-report.txt file says it's because this package has a targetSdkVersion < 4. I guess you need to specify targetSdkVersion in build.gradle of this package to fix this bug.

To Reproduce Steps to reproduce the behavior:

  1. Start with a Flutter app that does not require these permissions
  2. Add this plugin v2.0.0 and build the app again
  3. Now this app requests the aforementioned permissions. You can check it by opening app info on a device or by examining the final manifest file generated on build.

Expected behavior No new permissions added to an app.

bhumkong commented 1 year ago

Downgrading to 1.1.4 fixes the issue.