Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
121 stars 684 forks source link

The trashy state of disposals mass drivers #24649

Open TehSplinterCell opened 1 year ago

TehSplinterCell commented 1 year ago

Round ID: 9779

Testmerges: N/A

Reproduction:

Attempt to use a disposals mass driver on any of the following stations: Blueshift, Icebox, TramStation... actually, any map that has a mass driver to get rid of what passes through the crusher unharmed. I think all of them may be busted. The mass driver controls have an error message saying they're not hooked up to anything. They appear to be completely non-functional in this state.

Also worth noting: I've only ever seen the stacking machine stack carp scales. Other materials seem to simply vanish, including cardboard. As far as I'm aware, cardboard doesn't go into the ore silo, so where are the mats going? And why does it succeed at stacking space carp scales? (edit: Nevermind, it does stack cardboard. It simply doesn't show in the ore redemption machine. This aspect may be a non-issue.)

OrionTheFox commented 1 year ago

A note on the Stacking Machine part, the materials get bluespaced into the Ore Silo. The only ones that don't are ones that can't fit in there, I.E. the carp scales. The cardboard not showing at all would be a separate bug though. It IS intended to stay in the Stacking Machine, since the silo can't fit it...

vinylspiders commented 1 year ago

Related to https://github.com/Skyrat-SS13/Skyrat-tg/issues/24333 possibly? I was not able to reproduce this locally

TehSplinterCell commented 1 year ago

Quite possibly. I haven't played cargo on Void Raptor, so I've never had access to that specific driver. In either case, the live server only ever seems to have the 'toggle outer door' button as a valid option on all the drivers I have tried..

TehSplinterCell commented 1 year ago

Update: The mass driver is working on Tramstation and the stacking machine stacks cardboard without sending it to the shadow realm and/or ore silo. The only issue I'm actually finding is that the 'toggle outer door' button of the mass driver interface claims to be hooked up to nothing. The separate button on the wall nearby does toggle the outer door, but I've failed to locate anything to toggle the inner door. You're either venting tramstation disposals or not launching anything. Pick your poison.

I'm not convinced I didn't just Mandela Effect myself with the cardboard issue. Will test more later. Issue seems at least partially resolved.

Blueshift's mass driver is unconnected as of round 9818