Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
121 stars 685 forks source link

[MIRROR] Bow Update: Fletching instruction manual, bows using projectile damage multipliers, unhardcoded bow sprites, hot pink death #28683

Closed SkyratBot closed 2 months ago

SkyratBot commented 3 months ago

Original PR: https://github.com/tgstation/tgstation/pull/84435

About The Pull Request

Adds a new crate to the Service section of cargo. The Fletching and Bow-Making Starter Kit. Comes with some materials and a fletching instruction manual.

The manual teaches you how to make shortbows (18 force from normal arrows utilizing projectile multipliers), arrows, holy arrows (but you need a divine bow to make them), quivers (but they only hold 10 arrows), plastic arrows and violins. For reasons.

image

Fixes

Bows now no longer utilize hardcoded sprites for their loaded sprite. Now they use overlays.

Bows properly become undrawn once fired. No longer can your bow magically launch arrows by sheer force of will.

Why It's Good For The Game

Initially I just wanted to provide a way for bow wielding chaplains to produce additional arrows for their bow. Running out of those always felt pretty lame. But then I got to thinking; actually, I kind of want to LARP sometimes as an archer. I think that'd be kind of goofy and fun. So I bundled that together into a solution for both.

The shortbow is really, really not meant to be a meaningful weapon. It's just kind of silly, and meant to let people pretend to be Robin Hood and occasionally hurt someone in a workplace accident. I'm particularly thinking of clowns being the perfect users for this with their clumsy trait. I will make this weaker if I have too.

(I am not, at this moment, redoing flaming arrows okay? I saw the code comment. I know. Not right now. @ tralezab, if you have any flaming arrow sprites lying around, please let me know.)

Changelog

:cl: add: Fletching starter kit! Make your own bow, shoot your friends in an unfortunate workplace accident. Replace all those holy arrows you lost. fix: Bows now properly undraw once they have fired an arrow. code: Bows now utilize overlays in order to display loaded arrows. Unique overlays per arrow. /:cl:

projectkepler-ru commented 3 months ago

HOLD OFF ON MERGING @SpaceLoveSs13

projectkepler-ru commented 2 months ago

jfc all the failing linter is going to drive me insane