While poking around I figured now's the best time to make this thing TypeScript. So the entire chat settings ui has been refactored, cleaned up, typescripted. Functionality remains the same.
Why It's Good For The Game
Fixes #84593
Changelog
:cl:
fix: Fixed the bluescreen while setting a custom font in tgui panel
/:cl:
Original PR: https://github.com/tgstation/tgstation/pull/84601
About The Pull Request
Issue was caused by the fact that it was forwarding the custom font event rather than the string value. Caused by #82652. onChange is
event, value. See the problem here: https://github.com/tgstation/tgstation/blob/c9e785ce3e825edb16d2b560f79d568e3fbe4fc6/tgui/packages/tgui-panel/settings/SettingsPanel.jsx#L143-L149While poking around I figured now's the best time to make this thing TypeScript. So the entire chat settings ui has been refactored, cleaned up, typescripted. Functionality remains the same.
Why It's Good For The Game
Fixes #84593
Changelog
:cl: fix: Fixed the bluescreen while setting a custom font in tgui panel /:cl: