Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
121 stars 686 forks source link

[MIRROR] Special radio channels now use bitflags instead of individual vars #29463

Open SkyratBot opened 3 weeks ago

SkyratBot commented 3 weeks ago

Original PR: https://github.com/tgstation/tgstation/pull/85150

About The Pull Request

Radios/encryption keys now use a RADIO_SPECIAL_XXXXX bitflag for behaviors related to "special" radio channels (Binary, Centcom, Syndie).

I decided to do this because I wanted to add a radio channel for pirates and hunters (hence the branch name), but it felt weird adding two more variables. The more I look at the changes I've made here the more I realize that the effort was probably not worth the utility but whatever.

This also subtypes some varedited intercoms and makes them their own objects.

Why It's Good For The Game

Compresses a whopping three (3!) variables into a single one. Easier to scale (I guess?). I felt like adding a fourth/fifth variable and just moving on with the original project, but decided "lets do this the unnecessarily hard way instead".

Changelog

:cl: Rhials code: Radios/encryption keys now use a single variable for "special" frequencies. Please report if you experience any strangeness with accessing/being unable to access the Centcom, Syndicate, or Cyborg radio. /:cl: