Currently to check for Silicon access, we do:
if is silicon or is admin ghost or has unlimited silicon privileges or has machine remote in hand
What has unlimited silicon privileges? Bots, Drones, and admin ghosts.
To check for AI access, it just checks for AI instead of silicon, and doesnt check for unlimited silicon privileges.
This was kinda silly, so I thought I should make this a little easier to understand.
Now all silicon/ai traits come from AI_ACCESS_TRAIT or SILICON_ACCESS_TRAIT. I made a single exception to keep Admin ghost, since now instead of being a var on the client, we moved it to using the same trait but giving it to the client instead, but since we have to keep parity with previous functionality (admins can spawn in and not have this on, it only works while as a ghost), I kept previous checks as well.
No more type checks, removes a silly var on the mob level and another on the client.
Now while I was doing this, I found a lot of tgui's ui_act still uses usr and the wrong args, so I fixed those wherever I saw them, and used a mass replace for the args.
Other changes:
machinery's ui_act from https://github.com/tgstation/tgstation/pull/81250 had isAI replaced with HAS_AI_ACCESS, this has been reverted. Machine wands and admin ghosts no longer get kicked off things not on cameras. This was my fault, I overlooked this when adding Human AI.
Human AI's wand gives AI control as long as it's in your hand, you can swap to your offhand. I hope this doesn't end up going horribly, otherwise I'll revert this part. It should let human AIs not have their UI closed on them when swapping to eat food or use their door wand or whatnot.
Bots previously had special checks to scan reagents and be unobservant, I replaced this with giving them the trait. I also fixed an instance of unobservant not being used, so now statues don't affect the basic creature, whatever that is.
Why It's Good For The Game
This is an easier to understand way of handling silicon access and makes these mobs more consistent between eachother.
Other than what I've mentioned above, this should have no impact on gameplay itself.
Changelog
:cl:
fix: Statues don't count as eyes to creatures.
fix: Human AIs and Admin ghosts no longer get kicked off of machines that aren't on cameranets.
/:cl:
Original PR: https://github.com/tgstation/tgstation/pull/84964
About The Pull Request
Currently to check for Silicon access, we do:
if is silicon or is admin ghost or has unlimited silicon privileges or has machine remote in handWhat has unlimited silicon privileges? Bots, Drones, and admin ghosts. To check for AI access, it just checks for AI instead of silicon, and doesnt check for unlimited silicon privileges.This was kinda silly, so I thought I should make this a little easier to understand. Now all silicon/ai traits come from
AI_ACCESS_TRAITorSILICON_ACCESS_TRAIT. I made a single exception to keep Admin ghost, since now instead of being a var on the client, we moved it to using the same trait but giving it to the client instead, but since we have to keep parity with previous functionality (admins can spawn in and not have this on, it only works while as a ghost), I kept previous checks as well.No more type checks, removes a silly var on the mob level and another on the client.
Now while I was doing this, I found a lot of tgui's
ui_actstill usesusrand the wrong args, so I fixed those wherever I saw them, and used a mass replace for the args.Other changes:
ui_actfrom https://github.com/tgstation/tgstation/pull/81250 hadisAIreplaced withHAS_AI_ACCESS, this has been reverted. Machine wands and admin ghosts no longer get kicked off things not on cameras. This was my fault, I overlooked this when adding Human AI.Why It's Good For The Game
This is an easier to understand way of handling silicon access and makes these mobs more consistent between eachother. Other than what I've mentioned above, this should have no impact on gameplay itself.
Changelog
:cl: fix: Statues don't count as eyes to creatures. fix: Human AIs and Admin ghosts no longer get kicked off of machines that aren't on cameranets. /:cl: