Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
121 stars 686 forks source link

[MIRROR] Death of mutant bodyparts AND external organs #29490

Open SkyratBot opened 3 weeks ago

SkyratBot commented 3 weeks ago

Original PR: https://github.com/tgstation/tgstation/pull/85137

About The Pull Request

Removes mutant bodyparts and external organs from the game completely Digitgrade behaviour was mutant bodypart for no reason

Cat ears now work with the bodyparts overlay system, same as all the other external organs (since all their behaviour is now just on /organ

It doesn't remove all the /external types, but moves all behaviour to /organ. I'll follow up with a PR wiping all the /external organ types, but it's just conflict heaven so not this PR

I've also streamlined a lot of duplicate/weird species regeneration code

Melbert did the same PR as well but due to a lack of time (?) I have absorbed his PR to double nuke mutant bodyparts

Why It's Good For The Game

Frees us from the chain of unmodular code, and kills my greatest nemesis (after the shuttle meteor murder bug)

Changelog

:cl: Time-Green and MrMelbert Refactor: External organ behaviour has been moved to /organ, ears now use the same system as the other organs Refactor: Mutant bodyparts are dead! This likely does not mean much to the average person but it's very dear to me code: Improves digitgrade handling in preference code /:cl:

I have absorbed #85126, using Melberts code to improve and add some missing changes. Mainly improving the functioning of preferences and digitgrade legs. I didn't take over the hairstyle improvements.