search

Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
121 stars 685 forks source link

Adds maint requirement to kilo animal pen #29601

Closed Shroopy closed 3 weeks ago

Shroopy commented 2 months ago

About The Pull Request

Adds a maint access requirement to the animal pen on kilostation, so the animals don't just wander out.

How This Contributes To The Skyrat Roleplay Experience

The animals should stay in their pens.

Proof of Testing

It compiles.

Screenshots/Videos

Changelog

:cl: fix: Added a maint access requirement to the animal pen on kilo, so the animals won't wander out. /:cl:

github-actions[bot] commented 2 months ago

You currently have a negative Fix/Feature pull request delta of -1. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

Shroopy commented 2 months ago

Do you mean the access mapping helpers? I haven't seen those being used on windoors, the access is coded directly in like this one.

github-actions[bot] commented 1 month ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

Shroopy commented 1 month ago

@projectkepler-ru

github-actions[bot] commented 1 month ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

Shroopy commented 1 month ago

This is ready to be merged

github-actions[bot] commented 1 month ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.