Running LambdaGuard without AWS Profile

Skyscanner / LambdaGuard

AWS Serverless Security

Apache License 2.0

400 stars 69 forks source link

Running LambdaGuard without AWS Profile #30

Closed nwestfall closed 4 years ago

nwestfall commented 4 years ago

Resolves issue #29

When creating the ACL class in STS, the access_key_id and secret_access_key were not being passed, like other objects in this tool. Once you follow the same pattern and pass them in, you can use the --keys attribute again.

nwestfall commented 4 years ago

I tried to fix the lint coverage, but it passes on my machine and doesn't have anything to do with the file that I touched. Please let me know how you want me to proceed.

adeptex commented 4 years ago

Hey @nwestfall thanks very much for submitting this. Sorry it took a while to get around to fixing this, but I finally addressed linting (https://github.com/Skyscanner/LambdaGuard/pull/33) and since your change was minimal, I merged it in here: https://github.com/Skyscanner/LambdaGuard/commit/aed3c140b2759beae7b16dd03645f7c59026deb3

Thanks again, and please open another PR/issue if there is any problems! Cheers