search

Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 540 forks source link

Swift 4.2 support #220

Closed djbe closed 5 years ago

djbe commented 6 years ago

This is needed to support Xcode 10 (beta). The codebase should still be compatible with Swift 4.1 (Xcode 9).

k0nserv commented 6 years ago

Hey sorry I've not had time to look at this yet. Can you check that it still works on Swift 3.2 projects?

djbe commented 6 years ago

@k0nserv That's what the Travis build is for 😄 We can't add Xcode 10 yet as a variation on TravisCI, but we should once it's available.

k0nserv commented 6 years ago

I haven't setup a matrix build so I doesn't actually run against Swift 3 I believe. I should do that though

djbe commented 6 years ago

Ah, right, I read too quickly through your comment.

k0nserv commented 5 years ago

I don't think this maintains support with all Swift versions. I've created #239 which should still work with all Swift versions. The matrix build is in place now

k0nserv commented 5 years ago

This was done in #239. Never the less thanks for pushing me to do it

djbe commented 5 years ago

Pretty sure this was still compatible with older swift versions, I made similar PRs for a bunch of other projects. But whatever works 🤷‍♂️, glad this project supports 4.2 now.