search

Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 542 forks source link

XCode 10 GM and Swift 4.2 fails to build #234

Closed jlaws closed 6 years ago

jlaws commented 6 years ago

Report

What did you do?

Built on XCode 10 GM

What did you expect to happen?

Build with no errors or warnings

What happened instead?

Failed to build

/Users/joelaws/Workspace/kratos/Pods/SkyFloatingLabelTextField/Sources/SkyFloatingLabelTextField.swift:85:21: 'NSAttributedStringKey' has been renamed to 'NSAttributedString.Key'
/Users/joelaws/Workspace/kratos/Pods/SkyFloatingLabelTextField/Sources/SkyFloatingLabelTextField.swift:85:21: 'NSAttributedStringKey' was obsoleted in Swift 4.2 (Foundation.NSAttributedStringKey)
/Users/joelaws/Workspace/kratos/Pods/SkyFloatingLabelTextField/Sources/SkyFloatingLabelTextField.swift:534:35: 'UIViewAnimationOptions' has been renamed to 'UIView.AnimationOptions'
/Users/joelaws/Workspace/kratos/Pods/SkyFloatingLabelTextField/Sources/SkyFloatingLabelTextField.swift:534:35: 'UIViewAnimationOptions' was obsoleted in Swift 4.2 (UIKit.UIViewAnimationOptions)

Environment

Xcode Version: XCode 10 GM SkyFloatingLabelTextField Version: 3.5.2 Deployment Target: iOS 11 Base SDK: iOS 12 Method of Integration: CocoaPods

Project that demonstrates the issue

n/a

k0nserv commented 6 years ago

Hey @jlaws, thanks for the report. Let me download the GM and have a look

bojanstef commented 6 years ago

I'm having a similar issue with Xcode Version 9.4.1 (9F2000) SkyFloatingLabelTextField Version: pod 'SkyFloatingLabelTextField' Deployment Target: iOS 11 Base SDK: iOS 12 Method of Integration: CocoaPods

bojanstef@mbp$ pod install 

Installing SkyFloatingLabelTextField (3.4.1)

[!] Error installing SkyFloatingLabelTextField
[!] /usr/local/bin/git clone https://github.com/Skyscanner/SkyFloatingLabelTextField.git /var/folders/_y/fmccqc9j7md7422mvvmgf9_m0000gn/T/d20180913-72525-1j0sjnk --template= --single-branch --depth 1 --branch v3.4.1

Cloning into '/var/folders/_y/fmccqc9j7md7422mvvmgf9_m0000gn/T/d20180913-72525-1j0sjnk'...
fatal: unable to access 'https://github.com/Skyscanner/SkyFloatingLabelTextField.git/': Could not resolve host: github.com
bojanstef commented 6 years ago

Nevermind, I got mine to work. Was weird terminal settings on my local.

Abdul-Hannan commented 6 years ago

Fails with swift 4.2

k0nserv commented 6 years ago

236 is in progress for Swift 4.2 support

k0nserv commented 6 years ago

Please give 3.6.0 a try which has Swift 4.2 support

jlaws commented 6 years ago

Works great, thank you!