search

Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 542 forks source link

Multi line error #243

Closed JigarPatel1234 closed 4 years ago

JigarPatel1234 commented 6 years ago

Is there any way to set multiline error in label, As this is the best floating label textfield till now, we just need one thing and that is multi line error support. if there is some way, please share it to us. Thank you

Xcode Version: 10 SkyFloatingLabelTextField Version:3.0 Deployment Target:10 Method of Integration: CocoaPods

KompoD commented 5 years ago

@k0nserv, it's interesting question. Please answer as soon as u can :)

k0nserv commented 5 years ago

Hey, no there's isn't support for that at the moment. I am not sure if it's a good idea to support that as it will cause they UI to "jump around" if the label itself is a single line. I think it would be better to add a shorter error and include something more complete elsewhere in your UI

RowanG1 commented 5 years ago

Hey, no there's isn't support for that at the moment. I am not sure if it's a good idea to support that as it will cause they UI to "jump around" if the label itself is a single line. I think it would be better to add a shorter error and include something more complete elsewhere in your UI

I think jumping around will work better. The problem is that you need to have error like : "Invalid Username. At least one character or digit". The "invalid username" for example needs to be included in error so the user can see which field it is.

Drusy commented 5 years ago

I can understand Skyscanner team don't want to implement this feature request, if your error message doesn't fit only on small screens such as iPhone SE, you still can consider using adjustsFontSizeToFitWidth on the component label:

titleLabel.adjustsFontSizeToFitWidth = true
titleLabel.minimumScaleFactor = 0.8
sivakumarec99 commented 5 years ago

Hi sir used your sours file. Good Design sir thank you so much. Good improve in lable animation.

On 23-Mar-2019, at 5:28 AM, RowanG1 notifications@github.com wrote:

Hey, no there's isn't support for that at the moment. I am not sure if it's a good idea to support that as it will cause they UI to "jump around" if the label itself is a single line. I think it would be better to add a shorter error and include something more complete elsewhere in your UI

I think jumping around will work better. The problem is that you need to have error like : "Invalid Username. At least one character or digit". The "invalid username" for example needs to be included in error so the user can see which field it is.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Skyscanner/SkyFloatingLabelTextField/issues/243#issuecomment-475819376, or mute the thread https://github.com/notifications/unsubscribe-auth/AV7nLqEapRe3hqDVGOhh25LHbLSqPKF2ks5vZW44gaJpZM4XDV5i.