Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 542 forks source link

modified example and added description about #248

Closed devmjun closed 5 years ago

devmjun commented 5 years ago

I have modified example for Error state and delegates. When I use SkyFloatingLabelTextField, I think the example isn't proper at README.md

Because when user typing, func textField(_ textField: UITextField, shouldChangeCharactersIn range: NSRange, replacementString string: String) -> Bool method is called but This method's textfield.text bring value that previous value currently entered.

if a user is typing "A", textfield.text is "", if a user is typing "AB", textfield.text is "A". and then if a user is removing "B" of "AB", textfield.text is "AB". so I think that this situation can cause to be confused.

k0nserv commented 5 years ago

Thanks @devmjun 👍