Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.1k stars 541 forks source link

IconImage Issues #264

Open fattynomnom opened 5 years ago

fattynomnom commented 5 years ago

ℹ Please fill out this template when filing an issue. All lines beginning with an ℹ symbol instruct you with what info we expect. Please remove this line and all above before submitting.

Before you start, are you using the latest SkyFloatingLabelTextField release? Yes Issues are for feature requests, and bugs; questions should go to Stack Overflow with the tag skyfloatinglabeltextfield.

Report

What did you do?

Changed iconTypeValue to 1 as well as used the code iconType: .image programmatically. Applied an image to the iconImage property in the Attributes Inspector and adjusted iconColor on the Attributes Inspector.

What did you expect to happen?

Expected iconColor to change as selected

What happened instead?

iconColor remained blue instead (which is not the color selected nor I assume, is its default color based on the swift documentation)

Environment

ℹ Please fill in this section with information about your environment

Xcode Version:10.0 SkyFloatingLabelTextField Version:3.6.0 Deployment Target:iPhone XS Base SDK:iOS 12 Method of Integration: CocoaPods

Project that demonstrates the issue

ℹ Please link to a project we can download that reproduces the issue if applicable.

Bernix01 commented 5 years ago

See #274 added a little implementation supporting tint color, it works.

k0nserv commented 5 years ago

This has been merged and released in 3.7.0