search

Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 540 forks source link

Update to Xcode 10.2 and Swift 5.0 #272

Closed taher-mosbah closed 4 years ago

taher-mosbah commented 5 years ago

Run the migration assistant on framework and test apps, tests are green and 0 warnings.

taher-mosbah commented 5 years ago

Will update CI script as soon as Xcode 10.2 is available.

k0nserv commented 5 years ago

Thanks a bunch @taher-mosbah

k0nserv commented 5 years ago

Hey @taher-mosbah CI still seems to have issues here. Do you want to continue looking at it or should I pick it up?

taher-mosbah commented 5 years ago

Hey @k0nserv I won't have much time coming days, feel free to pick it up, really sorry for that.

dejanskledar commented 5 years ago

Any updates on this?

adamszeptycki commented 5 years ago

Any plans to merge it?

k0nserv commented 5 years ago

Hey, I don't have time to work on this, but I am happy to merge it if someone can create a PR that passes CI, specifically that still works for Swift 3.1 which seems broken in this PR

k0nserv commented 5 years ago

I've released version 3.7.0 which specifies the swift_versions attribute in the podspec. This should mean that you can use SkyFloatingLabelTextField in your Swift 5 projects before someone gets the time to look at and finish this PR

k0nserv commented 4 years ago

Closed in favour of #290