search

Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 540 forks source link

How to make titileLabel multi-line? #307

Closed mohsinsurani closed 4 years ago

mohsinsurani commented 4 years ago

ℹ Please fill out this template when filing an issue. All lines beginning with an ℹ symbol instruct you with what info we expect. Please remove this line and all above before submitting.

Before you start, are you using the latest SkyFloatingLabelTextField release?

Issues are for feature requests, and bugs; questions should go to Stack Overflow with the tag skyfloatinglabeltextfield.

Report

What did you do?

change no. of lines to 2 to get it multi - line ℹ Please replace this with what you did.

What did you expect to happen?

It should come multiple line ℹ Please replace this with what you expected to happen.

What happened instead?

It came single line ℹ Please replace this with of what happened instead.

Environment

ℹ Please fill in this section with information about your environment

Xcode Version: 11.2.1 SkyFloatingLabelTextField Version: latest Deployment Target: 11 Base SDK: Method of Integration: CocoaPods

Project that demonstrates the issue

ℹ Please link to a project we can download that reproduces the issue if applicable.

k0nserv commented 4 years ago

You might be able to do it by setting titleLabel.numberOfLines

mohsinsurani commented 4 years ago

Its not working!

k0nserv commented 4 years ago

In that case it's considered unsupported

mohsinsurani commented 4 years ago

In that case, Is anyone going to take this up?

k0nserv commented 4 years ago

No, and I'm concerned about feature creep in this library so I would not be accepting a pull request changing it. You should be able to achieve by subclassing SkyFloatingLabelTextField and changing it yourself

mohsinsurani commented 4 years ago

Yes. I fixed it! Thanks

ZaeemZafar commented 4 years ago

@mohsinsurani Can you post applied fix here. Need that solution. Thanks