Skyscanner / SkyFloatingLabelTextField

A beautiful and flexible text field control implementation of "Float Label Pattern". Written in Swift.
Apache License 2.0
4.09k stars 540 forks source link

Xcode 12 SPM `IPHONEOS_DEPLOYMENT_TARGET` warning #324

Closed diogot closed 3 years ago

diogot commented 3 years ago

Report

What did you do?

Using SkyFloatingLabelTextField in SPM on Xcode 12 GM.

What did you expect to happen?

Don't show any build warning.

What happened instead?

Produces this warning:

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

Environment

Xcode Version: 12 GM SkyFloatingLabelTextField Version: 3.8.0 Deployment Target: iOS 12 Base SDK: iOS 14 Method of Integration: SPM

According to this thread the problem is that this line is overriding Xcode settings forcing IPHONEOS_DEPLOYMENT_TARGET to an unsupported SDK version by Xcode 12.

The solution on the thread was remove the platforms section, because they support all platforms/versions so this might not work in this case.

bogren commented 3 years ago

There is more info on in Cocoapods issue section https://github.com/CocoaPods/CocoaPods/issues/9884. I can create a PR bumping the deployment target as well 👍

kristiyandobrev commented 3 years ago

@bogren That would be really nice! I guess the same could be done for SPM as I am getting similar warning

Screenshot 2020-09-30 at 10 27 33

bogren commented 3 years ago

Yes 👍 Bumped in #325. Need to release.

kristiyandobrev commented 3 years ago

@bogren the iOS version in Package.swift is still set to 8.0 though 🤔

k0nserv commented 3 years ago

I'll try to get a new version out with these fixes today

ostoich commented 3 years ago

@k0nserv will you be updating the Package.swift file any time soon? It is still set to 8.0 and is causing issues with SPM on XCode 12.

devgeek27 commented 3 years ago

Same for me. Could you please fix that for SPM.

ostoich commented 3 years ago

@k0nserv Xcode 12 is now official. Please update the platforms in Package.swift as you promised. There are a number of people here waiting on you since October 2 for this fix.

k0nserv commented 3 years ago

Thanks for the reminder, 4.0.0 is out now with the bump

diogot commented 3 years ago

Thanks!