Skyscanner / backpack

Backpack Design System for the Web
https://skyscanner.design
Apache License 2.0
496 stars 185 forks source link

LOOM-1540: tsx migration for splitinput and inputField components #3565

Closed Parisistan closed 1 month ago

Parisistan commented 1 month ago

Giving splitInputs some typescript LOVE. Add form test for splitInput

FYI: Had to ignore a lint for one of the test because otherwise we'd need to write a recursive promise chain to do it and it's unnecessarily complicated for this simple test. 🙂

Remember to include the following changes:

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

github-actions[bot] commented 1 month ago
Warnings
:warning: Package source files (e.g. `packages/package-name/src/Component.js`) were updated, but snapshots weren't. Have you checked that the tests still pass?
:warning: Package source files (e.g. `packages/package-name/src/Component.tsx`) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by :no_entry_sign: dangerJS against b1c36471bb819f24d1e6b0781ee599d55b23b99f

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.

olliecurtis commented 1 month ago

With the new change to this property this will change the contract with consumers, so we will need to move the label on this PR to be major :)

github-actions[bot] commented 1 month ago

Visit https://backpack.github.io/storybook-prs/3565 to see this build running in a browser.