search

Skyscanner / skyscanner-python-sdk

Skyscanner Python SDK
Other
122 stars 33 forks source link

handling for 304 not modified responses #11

Open joesarre opened 9 years ago

joesarre commented 9 years ago

Added a fix for response = None

ardydedase commented 9 years ago

Hi @joesarre,

Unit tests are broken for this pull request: https://travis-ci.org/Skyscanner/skyscanner-python-sdk/builds/81211741 and coverage have decreased.

Looks like we'll need to update the unit tests for this pull request.

Thanks, Ardy

joesarre commented 9 years ago

Cheers, yeah I'll have another go at it when I can. I think the tests are failing because of the rate limit, but agree on coverage. Hard to test for as that code path requires the underlying API to return a 304 which only happens occasionally. I stopped short of introducing mocks into the tests. On 19 Sep 2015 21:47, "Ardy Dedase" notifications@github.com wrote:

Hi @joesarre https://github.com/joesarre,

Unit tests are broken for this pull request: https://travis-ci.org/Skyscanner/skyscanner-python-sdk/builds/81211741 and coverage have decreased.

Looks like we'll need to update the unit tests for this pull request.

Thanks, Ardy

— Reply to this email directly or view it on GitHub https://github.com/Skyscanner/skyscanner-python-sdk/pull/11#issuecomment-141748295 .