search

SkytAsul / BeautyQuests

A quests plugin based on a simple-to-use graphical interface (Minecraft)
MIT License
155 stars 33 forks source link

Added FancyNpcs integration #331

Closed OakLoaf closed 3 months ago

OakLoaf commented 3 months ago

I haven't been able to test this because I don't have all of the dependencies maven installed. If there is anything immediately obvious that is missing please let me know.

Also if someone would be able to compile this PR for me to test that'd be wonderful :)

OakLoaf commented 3 months ago

Whilst I still haven't tested this exact jar I have made an addon jar that is working with the same code (Hence the fixes)

SkytAsul commented 3 months ago

Seems good! I have compiled a version of BeautyQuests with this fix included, may I send it to you on Discord so you can test it?

OakLoaf commented 3 months ago

Sure, my discord is @oakloaf

SkytAsul commented 3 months ago

I can't add you as a friend, your requests are closed :sweat_smile: can you add me (@skytasul) or come on my Discord server?

OakLoaf commented 3 months ago

Ahh, I'll join your Discord

OakLoaf commented 3 months ago

Is there anything else that needs doing regarding this one?

SkytAsul commented 3 months ago

Nah it's completely fine, I'll merge soon.

SkytAsul commented 3 months ago

Thank you very much for the PR :)