search

SkytAsul / GlowingEntities

An API to easily make Minecraft entities glow. No dependencies, compatible 1.17 -> 1.21.
MIT License
62 stars 8 forks source link

Older 1.20 versions unsupported #16

Closed Agus5534 closed 3 months ago

Agus5534 commented 3 months ago

Hello! I would like to report a couple of bugs with the use of versions prior to 1.20.5 (GlowingEntities class)!

Mainly, watcherGet does not contain the al method. According to what I checked, there is not the previous adaptation that existed (it may not be this). Finally, another error occurs in the DataWatcher subclass declaration (line 421) because the condicional is erroneous, currently it is version >= 20 || (version == 20 && versionMinor >= 5), where version >= 20 must be version > 20

Thank you for your work, it is a great dependency and of very good quality!

Agus5534 commented 3 months ago

Extra: I didn't try it on older versions (1.19...)

SkytAsul commented 3 months ago

May you try with this commit? :)

Agus5534 commented 3 months ago

Yeaa thanks <3