SkytAsul / GlowingEntities

An API to easily make Minecraft entities glow. No dependencies, compatible 1.17 -> 1.21.
MIT License
68 stars 9 forks source link

1.21 Paperweight mappings not working #18

Closed OakLoaf closed 3 weeks ago

OakLoaf commented 4 months ago

I am trying to use 1.3.5 and it is only displaying a blue glow colour, I have migrated to the new group name in the dependency and it is correctly importing, when looking at the library within my source code I can see that there is mappings for 1.21 but when running the code I get the following logs in my console:

[GlowingEntities] [GlowingEntities] Found server version 1.21.0
[GlowingEntities] [GlowingEntities] Loaded not matching version of the mappings for your server version
[GlowingEntities] [GlowingEntities] Loaded mappings V1_20_5_REMAPPED
SkytAsul commented 4 months ago

I guess you are using a paper plugin? Using the remapped 1.21 environment?

OakLoaf commented 4 months ago

I do not use any nms in the project currently other than GlowingEntities but it is being ran on Paper 1.21 (Experimental Builds)

SkytAsul commented 4 months ago

Yes but is it a paper plugin or spigot plugin?

OakLoaf commented 4 months ago

It is a Paper plugin but does not use the paper-plugin.yml and is not remapped on compilation.

SkytAsul commented 4 months ago

I guess you are using the paperweight gradle plugin and your JAR gets compiled with the paperweight-mappings-namespace manifest attribute set mojang. Please change it to spigot. See PaperMC documentation: https://docs.papermc.io/paper/dev/project-setup#plugin-remapping.

OakLoaf commented 4 months ago

Unfortunately I had no luck when trying but it's all good, I'll just hold off until 1.21 remapped support is added :)

SkytAsul commented 4 months ago

It's probably not coming in the following days (I hope in a few weeks), because I don't have much time and it requires quite a refactoring (all classes have been renamed and other things like that). I started creating an util that will help in the future. In the meantime, check the MANIFEST.MF file in your archive and see if it contains the remapping bit. Also, please send me your server logs.

OakLoaf commented 3 months ago

Apologies for the late response. I depend on the paper-api but I don't use any of the paperweight plugins, I just compile with shadowJar, what logs in particular are you looking for? Just startup?

SkytAsul commented 3 months ago

Yup startup logs please! No worries for the late response :)

OakLoaf commented 3 months ago

I lied, I do use paperweight, I was on the wrong branch

OakLoaf commented 3 months ago

I'm going to try doing this real quick: https://docs.papermc.io/paper/dev/userdev#compiling-to-spigot-mappings

OakLoaf commented 3 months ago

Can confirm, this resolved the issue

SkytAsul commented 3 months ago

Perfect! In the meantime, I continued working on adding support for the remapped version :)

OakLoaf commented 1 month ago

Just thought I'd correct the title of this to be less misleading :)

SkytAsul commented 3 weeks ago

It was HARD but finally: you can now use GlowingEntities on non-remapped servers!