search

SkytAsul / JukeBox

A Minecraft Spigot plugin which allows you to propose note block songs/musics to your players.
MIT License
22 stars 14 forks source link

Many messages not configurable #25

Closed notenoughbees closed 3 years ago

notenoughbees commented 3 years ago

On my Paper 1.16.4 server, running Jukebox 1.19.5, at least a third of the messages in en.yml aren't actually configurable.

I went to see just how many aren't configurable by setting every single message to "x", and the messages that didn't change were these: TOGGLE_PLAYING RANDOM_MUSIC STOP MUSIC_STOPPED RELOAD_LAUNCH PLAYLIST_ITEM OPTIONS_ITEM MENU_ITEM CLEAR_PLAYLIST NEXT_ITEM CHANGE_PLAYLIST CHANGE_PLAYLIST_LORE PLAYLIST FAVORITES RADIO

Most of them are GUI messages, and a lot of them are important messages like the titles of buttons, so it'd be massively great to have this fixed :)

messages

SkytAsul commented 3 years ago

All of those actually are configurable. Have you tried restarting the server instead of just reloading the plugin? I'm caching the items with their names at startup to not overload the server.

notenoughbees commented 3 years ago

Yes I was just reloading instead of restarting, just restarted now and it all works! I'll close this, thanks :)