Closed My-Name-Is-Jeff closed 4 months ago
This PR has 149
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
The behavior changes from running every tick to running every game loop
How does coroutine work? I think they accomplish the same thing unless Minecraft is running behind on ticks
The behavior changes from running every tick to running every game loop
How does coroutine work? I think they accomplish the same thing unless Minecraft is running behind on ticks
Well since the coroutine scope has a MC executor as a dispatcher, it's going to queue the tasks there. AFAICT, MC's addScheduledTask
executes every game loop as opposed to every game tick.
The behavior changes from running every tick to running every game loop
How does coroutine work? I think they accomplish the same thing unless Minecraft is running behind on ticks
Well since the coroutine scope has a MC executor as a dispatcher, it's going to queue the tasks there. AFAICT, MC's
addScheduledTask
executes every game loop as opposed to every game tick.
Delay behavior should be the same if each tick takes 50ms right? Should be fine because ticks also happen in game loop
The behavior changes from running every tick to running every game loop
How does coroutine work? I think they accomplish the same thing unless Minecraft is running behind on ticks
Well since the coroutine scope has a MC executor as a dispatcher, it's going to queue the tasks there. AFAICT, MC's
addScheduledTask
executes every game loop as opposed to every game tick.Delay behavior should be the same if each tick takes 50ms right? Should be fine because ticks also happen in game loop
I think game loops aren't aligned to ticks since game loops are also where the game renders each frame. The delay behavior makes sense but it wouldn't be synced to a tick to begin with.
Superseded by 7a741404e010ba19f6b52477341b5720e31c04a7
Could completely remove ticktask maybe?