Closed TakoTheDev closed 3 months ago
This PR has 4
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
2 issues: both in line 603
It basically only modified the check in line 595 before, meaning the opacity was 0 * 256 / 10 which is still 0 and stopped it from rendering. Second issue is that 1 is only barely visible, so 10 is used instead, as that is the max needed basically.
iirc this class is replaced by optifine? did you check in game
Oh yea optifine also messes with it
This PR has 11
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 10
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This PR has 10
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
2 issues: both in line 603
It basically only modified the check in line 595 before, meaning the opacity was 0 * 256 / 10 which is still 0 and stopped it from rendering.
Second issue is that 1 is only barely visible, so 10 is used instead, as that is the max needed basically.