search

Skyvern-AI / skyvern

Automate browser-based workflows with LLMs and Computer Vision
https://www.skyvern.com
GNU Affero General Public License v3.0
10.73k stars 739 forks source link

increase timeout for scrolling #1145

Closed LawyZheng closed 2 weeks ago

LawyZheng commented 2 weeks ago

[!IMPORTANT] Increase scrolling timeout by introducing BUILDING_ELEMENT_TREE_TIMEOUT_MS and updating relevant functions in scraper.py and page.py.

  • Timeout Changes:
    • Introduce BUILDING_ELEMENT_TREE_TIMEOUT_MS in constants.py set to 60,000 ms (1 minute).
    • Replace hardcoded timeout_ms=60 * 1000 with timeout_ms=BUILDING_ELEMENT_TREE_TIMEOUT_MS in get_interactable_element_tree_in_frame(), get_interactable_element_tree(), and get_incremental_element_tree() in scraper.py.
    • Update scroll_to_top() and scroll_to_next_page() in page.py to use BUILDING_ELEMENT_TREE_TIMEOUT_MS for timeout_ms.

This description was created by Ellipsis for 15fa48f89e0f4ac275e29ca4670a9dd375e062ab. It will automatically update as commits are pushed.