search

Skyvern-AI / skyvern

Automate browser-based workflows with LLMs and Computer Vision
https://www.skyvern.com
GNU Affero General Public License v3.0
5.46k stars 395 forks source link

exclude aria-hidden elements #557

Closed LawyZheng closed 1 day ago

LawyZheng commented 1 week ago
:rocket: This description was created by Ellipsis for commit 621daf3132f43c516c9e66762067cc2b6970fe47

Summary:

Updated isElementVisible in skyvern/webeye/scraper/domUtils.js to exclude elements with aria-hidden='true'.

Key points:

Generated with :heart: by ellipsis.dev

LawyZheng commented 1 week ago

there is already a isHidden function in this file, we should update it instead.

we only use the isHidden function for option element, should I enable it to use for all elements ?

LawyZheng commented 1 day ago

Close this PR since it's still controversial to make this change.