We've seen tasks getting stuck when closing playwright browsers. As a result, webhook requests were not successfully sent.
reordering the logic so that we send webhook request before closing the browser window.
:rocket:
This description was created by Ellipsis for commit e9fa2f6b079133a8b6775b3f91af90bf8d925094
Summary:
Modified send_task_response in skyvern/forge/agent.py to send the webhook response before closing the browser to prevent delays caused by browser closure issues.
Key points:
File Modified: skyvern/forge/agent.py
Function Modified: send_task_response
Change: Moved the call to cleanup_browser_and_create_artifacts to after execute_task_webhook in send_task_response.
Reason: Ensures the webhook response is sent before closing the browser, which often gets stuck during closure.
We've seen tasks getting stuck when closing playwright browsers. As a result, webhook requests were not successfully sent.
reordering the logic so that we send webhook request before closing the browser window.
Summary:
Modified
send_task_response
inskyvern/forge/agent.py
to send the webhook response before closing the browser to prevent delays caused by browser closure issues.Key points:
skyvern/forge/agent.py
send_task_response
cleanup_browser_and_create_artifacts
to afterexecute_task_webhook
insend_task_response
.Generated with :heart: by ellipsis.dev