search

Skywalker97 / FileExplorer1.0

0 stars 2 forks source link

Organize code into MVP or MVVM architecture. #1

Open Skywalker97 opened 7 years ago

Skywalker97 commented 7 years ago

No need to add any functionality as such, just reorganize the code. :)

vchernogorov commented 7 years ago

I guess you should add CONTRIBUTING.md file first?

codeteo commented 7 years ago

Hi @Skywalker97 , I'm interested in working on this issue.

I've got two questions :

  1. MVVM with data binding or with RxJava ? Or both depending on the case ?
  2. After I quick lookup on the code I noticed nested adapter class, commented out code that is not removed and some other minor issues like code formatting. Can I also try to deal with these issues too in the same PR ?
  3. Some drawables are missing from mipmap folder ( names : file, instorage and sdcard ). Could you, please, push a commit with the missing files cause I'm not able to build the project without them ?

Edit : added a 3rd question

ghost commented 7 years ago

@Skywalker97 maybe i can help with added some unit test