search

Skywire / m2-travis

M2 travis configuration
Open Software License 3.0
0 stars 0 forks source link

Travis usage #6

Closed valguss closed 4 years ago

valguss commented 4 years ago

When this package is used in travis, it overwrites any customisations we've made. Might be worth adding this the to the --require-dev section instead?

Demoli commented 4 years ago

Yes try it in require-dev, them we can commit the composed files on first install.

valguss commented 4 years ago

Just tried on FL and it still gets overrided. Guess composer is using composer install instead of composer install --no-dev Investigating

valguss commented 4 years ago

Ended up having to remove the package as m2 requires the dev packages for travis to work apparently

Demoli commented 4 years ago

Makes some sense, why is this only affecting FL is the question? Cordings should be using the same config.

On Tue, Dec 10, 2019 at 11:55 AM Tom Scott-Malden notifications@github.com wrote:

Ended up having to remove the package as m2 requires the dev packages for travis to work apparently

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Skywire/m2-travis/issues/6?email_source=notifications&email_token=AAIB33MQP6QCCGKSQ25WN7TQX57SZA5CNFSM4JY4FIWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGO7IWY#issuecomment-563999835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIB33PC6MZHWSY4ROLR4SDQX57SZANCNFSM4JY4FIWA .

-- Neil Aitken Senior Magento Developer Skywire Ltd n.aitken@gmail.com

valguss commented 4 years ago

It's been removed from Cordings too :)

On Tue, Dec 10, 2019 at 11:58 AM Neil Aitken notifications@github.com wrote:

Makes some sense, why is this only affecting FL is the question? Cordings should be using the same config.

On Tue, Dec 10, 2019 at 11:55 AM Tom Scott-Malden < notifications@github.com> wrote:

Ended up having to remove the package as m2 requires the dev packages for travis to work apparently

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/Skywire/m2-travis/issues/6?email_source=notifications&email_token=AAIB33MQP6QCCGKSQ25WN7TQX57SZA5CNFSM4JY4FIWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGO7IWY#issuecomment-563999835 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAIB33PC6MZHWSY4ROLR4SDQX57SZANCNFSM4JY4FIWA

.

-- Neil Aitken Senior Magento Developer Skywire Ltd n.aitken@gmail.com

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Skywire/m2-travis/issues/6?email_source=notifications&email_token=AAAZ3RPJGRN3C2NWB4GZ7ZLQX575DA5CNFSM4JY4FIWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGO7QHQ#issuecomment-564000798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ3RPNBACBKFWDB63NV33QX575DANCNFSM4JY4FIWA .

Demoli commented 4 years ago

Righto, well that explains that.

We probably want to just install this as a one off package then, will look at a good strategy for that, maybe just manually install it during initial project setup.

On Tue, Dec 10, 2019 at 12:31 PM Tom Scott-Malden notifications@github.com wrote:

It's been removed from Cordings too :)

On Tue, Dec 10, 2019 at 11:58 AM Neil Aitken notifications@github.com wrote:

Makes some sense, why is this only affecting FL is the question? Cordings should be using the same config.

On Tue, Dec 10, 2019 at 11:55 AM Tom Scott-Malden < notifications@github.com> wrote:

Ended up having to remove the package as m2 requires the dev packages for travis to work apparently

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <

https://github.com/Skywire/m2-travis/issues/6?email_source=notifications&email_token=AAIB33MQP6QCCGKSQ25WN7TQX57SZA5CNFSM4JY4FIWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGO7IWY#issuecomment-563999835

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAIB33PC6MZHWSY4ROLR4SDQX57SZANCNFSM4JY4FIWA

.

-- Neil Aitken Senior Magento Developer Skywire Ltd n.aitken@gmail.com

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/Skywire/m2-travis/issues/6?email_source=notifications&email_token=AAAZ3RPJGRN3C2NWB4GZ7ZLQX575DA5CNFSM4JY4FIWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGO7QHQ#issuecomment-564000798 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAZ3RPNBACBKFWDB63NV33QX575DANCNFSM4JY4FIWA

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Skywire/m2-travis/issues/6?email_source=notifications&email_token=AAIB33JRLP4LLBU4I4PMMM3QX6D3XA5CNFSM4JY4FIWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGPCHCA#issuecomment-564011912, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIB33KZR6WQU3XMM7H5FQTQX6D3XANCNFSM4JY4FIWA .

-- Neil Aitken Senior Magento Developer Skywire Ltd n.aitken@gmail.com

Demoli commented 4 years ago

I've implemented a new file copy strategy which should only copy the files the first time this module is installed, it won't overwrite any existing files.

This means we can still use composer, but change the files as required.