SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
556 stars 114 forks source link

[Bug] External Images in Image Adjustments Snippet wont align #104

Closed StormsForDragon closed 2 years ago

StormsForDragon commented 2 years ago

When using just the Image Adjustments snippet, I cannot get the external images to float or to position on the right or left sides. The only part that manages to work that I've found is the resizing and the color inversion. I can't get the grid to work either.

When I'm using internal images, it works perfectly fine. I know the formatting is correct (in theory) because when I've got the ITS theme installed, it works as described.

Things I've tried:

Did not try: Mobile. Didn't see the point if I can't get it to work on desktop! Changing versions. I'm on v0.14.6

I've got a sort of working secondary snippet running to do the aligning/float, but it's kind of awful compared to what I know this snippet can do! It's the first time I'm posting anything on github, let me know if I've missed something!

SlRvb commented 2 years ago

Hmmm, that shouldn't be happening ๐Ÿค”

Do you have an example of the note and the images you're trying to get working? Also which theme you're working with?

StormsForDragon commented 2 years ago

My apologies for the delay, life happened. I hope this helps?

SIRvb Image Adjustment Snippet example

SlRvb commented 2 years ago

Okay, if you update the snippet, locr and locl should now work! \:) cdc9cdf1a39260cda6bc7ce0951d383939008446

StormsForDragon commented 2 years ago

Thank you so much! Would you be able to check on the grid as well, it also doesn't seem to work by itself with external images. (I swear I meant to put that in the original post but was apparently too focused on the floating-location.) It's the same circumstance, only works within the theme, but not in the snippet by itself.

SlRvb commented 2 years ago

Interesting that it works in my theme as I've always had some trouble with the inline grid and external images ๐Ÿฅด

I'll see what the difference between my theme and the snippet is ๐Ÿ‘๐Ÿฝ

SlRvb commented 2 years ago

Hmmm, I don't think grid works with external images in general, I can't get it to align well enough even with my theme. If you have an example of that working do let me know, but I can't recreate that myself to check what's going on ๐Ÿ™ˆ

SlRvb commented 2 years ago

Feel free to reopen this issue if it's not fixed.