SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
531 stars 112 forks source link

Header Fold Icon Showing Behind Callout #111

Closed AmbushXXVI closed 2 years ago

AmbushXXVI commented 2 years ago

I'm currently using the ITS - WotC - Dark theme and native callouts. If I use a left aligned callout box near foldable headers, the arrow to fold shows behind the callout and is unclickable.

image

OS

Windows - Desktop Obsidian Version: 0.14.15

SlRvb commented 2 years ago

I think I've managed a fix for this. Do let me know if that helps with this πŸ™πŸ½ da2242f

AmbushXXVI commented 2 years ago

Hrm. I updated my theme through Obsidian and then restarted the app. I'm still seeing the issue, so my first question is: did I get the update as expected? If I clicked the update button from within themes, would that pick up the change?

SlRvb commented 2 years ago

Hmm, you're still seeing the issue? πŸ€” Update my theme one more time and if it's still broken could you screenshot what it looks like this time?

AmbushXXVI commented 2 years ago

Unfortunately. If it helps, I could probably create a tiny vault that does this. I've included the markdown that does it.

image


---
tag: pc
alias: Example
table-common: Example
class: My Class
session-ref: Example
species: Human
class: Cleric, Paladin
background: Guild Artisan
---

> [!infobox|left]  
> # `= this.file.name `
> ![[token_example.png|cover hsmall]]  
> <br/>
> ###### Sheet
> [Beyond](https://www.dndbeyond.com/characters/1234567)
> <br/>
> ###### Stats  
> Type | Β Stat |  
> ---|---|  
> Species | `= this.species ` |  
> Class | `= this.class ` |  
> Background | `= this.background ` |  

#### **Childhood**

_Got Some Issues_ 
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

#### **Teenage Years**

_Got Some More Issues_ 
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

#### **Adulting**

_Yup_ 
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
SlRvb commented 2 years ago

Hmmm, strangely enough I still can't seem to recreate this error even on the sandbox vault πŸ€”

Obsidian_bszsoKjsHI

Could you export your style settings and put that with the ITS theme css here to see if maybe something's going wrong with any of those?

AmbushXXVI commented 2 years ago

progress has been made! while going over the export of the ITS changes i've made, i decided to go poke around my appearance snippets. lo and behold, there's a callouts.css. and when i turn that snippet off, the fold icons push out to where they are supposed to be. it's definitely callouts from here, but an older version (from 6/9).

if i'm using the ITS theme, is it safe to assume that i don't need to manually add anything (and that i'd only need to enable that callouts.css if i'm using a different theme)?

SlRvb commented 2 years ago

Aaah, I thought perhaps a rogue callout.css snippet was the case.

Yes, if you use my theme, the same callouts from the snippet are already included in it so no need for the snippet. If you use other themes then you would need the separate snippet toggled on.

Sorry for the confusion, I didn't realize I didn't include that under the Snippets Already Included section of the readme πŸ™ˆ

SlRvb commented 2 years ago

I've also pushed that fix for the separate callout snippet if you need that snippet 05b0ec4

AmbushXXVI commented 2 years ago

Not that it super matters, but I think what happened was that I was using minimal, Josh did his video bit about the callouts, so I grabbed it, and then I was like, "his theme is way better than mine, i need to go get that thing" and didn't think about the fact that i already had a snippets piece loaded.

FWIW, sorry I had you running around looking for a ghost that only existed on my end. I know that pain well.