SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
531 stars 112 forks source link

Issues in 0.16.2 #131

Closed TayThorian closed 1 year ago

TayThorian commented 1 year ago

Hi.

Minor issue with the latest build.

If I go to settings, Appearance, I can't scroll down to the bottom of that list past 'Advanced' and see CSS Snippets.

If I change back to the default theme, it's okay.

SlRvb commented 1 year ago

What version of the ITS theme are you on?

TayThorian commented 1 year ago

Hi

Theme is Version 0.6.4

SlRvb commented 1 year ago

Can you replicate this in the sandbox vault? Click the I, then open Sandbox vault and install my theme 🙏🏽

TayThorian commented 1 year ago

Yes, same in Sandbox. Its actually slightly worse. Cannot scroll down on Appearance at all.

@.***

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: 07 September 2022 17:56 To: @.> Cc: @.>; @.> Subject: Re: [SlRvb/Obsidian--ITS-Theme] Issues in 0.16.2 (Issue #131)

Can you replicate this in the sandbox vault? Click the I, then open Sandbox vault and install my theme 🙏🏽

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSlRvb%2FObsidian--ITS-Theme%2Fissues%2F131%23issuecomment-1239647858&data=05%7C01%7C%7Cac86f54908f040f1243d08da90f1d280%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637981665600194418%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BIDq%2FgqlJSoCUQo8x7L5S0VlNwELBFqEZzOklMDDGRY%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJWJDFJGXSPWAIO7JN3ZYJDV5DCJPANCNFSM6AAAAAAQEUZB54&data=05%7C01%7C%7Cac86f54908f040f1243d08da90f1d280%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637981665600194418%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kllcLe4GuDs1G%2F1gd0HvReisQv6LGEHWUqT1KVhtvdE%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

SlRvb commented 1 year ago

I can't seem to recreate this, are you viewing this on a laptop? 🤔

TayThorian commented 1 year ago

I use a laptop with a 36" monitor

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: SlRvb @.> Sent: Thursday, September 8, 2022 8:13:56 PM To: SlRvb/Obsidian--ITS-Theme @.> Cc: TayThorian @.>; Author @.> Subject: Re: [SlRvb/Obsidian--ITS-Theme] Issues in 0.16.2 (Issue #131)

I can't seem to recreate this, are you viewing this on a laptop? 🤔

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSlRvb%2FObsidian--ITS-Theme%2Fissues%2F131%23issuecomment-1241123242&data=05%7C01%7C%7C1df76009404d481a89db08da91ce4729%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637982612380478242%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JZZE5ucFXHu4%2FfbUcpjBa0sPkiC3aGXtP9sUnQD5C9c%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJWJDFO2J3O7H3GCBRBLCALV5I3HHANCNFSM6AAAAAAQEUZB54&data=05%7C01%7C%7C1df76009404d481a89db08da91ce4729%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637982612380478242%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ExeIjoOa5BqhAQZy9bP9fiRTpWZHhO%2BWWVEpP%2FkUMq0%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

SlRvb commented 1 year ago

Any chance I could get a video/gif of this issue?

JarradTait commented 1 year ago

Scroll is broken for me too. This is as far as I can scroll on my setting page with ITS Theme

image

This is how far I should be able to scroll

image

JarradTait commented 1 year ago

Any chance I could get a video/gif of this issue?

2022-09-27 19-24-22

23maverick23 commented 1 year ago

I could be off base (I've only spent a few minutes tinkering), but it seems to be that the --setting-h variable is causing this issue on the modal window itself. The snippet is here:

.modal.mod-settings .vertical-tab-content-container, .modal.mod-settings .vertical-tab-header {
    height: var(--setting-h);
    padding: 0;
}

If you completely disable the height property here, you get full/normal scrolling back. Funny enough, changing this setting in Style Settings to 100vh still doesn't solve the issue - you need to remove/disable the setting completely.

I'm not sure where to adjust this as I haven't done any theme development for Obsidian, but thought this might help :)

SlRvb commented 1 year ago

Alright I believe I've fixed the issue, do let me know if it works 🙈

JarradTait commented 1 year ago

Alright I believe I've fixed the issue, do let me know if it works see_no_evil

working on my end!