SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
523 stars 112 forks source link

[Bug] Broken Timeline Callout #152

Closed EdualcLaiv closed 1 year ago

EdualcLaiv commented 1 year ago

Describe the bug

The timeline callout is not rendered properly. It's not correctly centered (especially the ๐Ÿ•›icon), and the vertical line looks broken.

Expected behavior It should look as showed in your guide: image

To Reproduce

  1. Install the theme in a new vault
  2. Use following code:
> [!timeline|t-l] **Title** _Subtitle_
> Left aligned timeline piece

> [!timeline|t-r] **Title** *Subtitle*
> Right aligned timeline piece

> [!timeline|t-l] **Title** _Subtitle_
> Left aligned timeline piece

> [!timeline|t-r] **Title** *Subtitle*
> Right aligned timeline piece

Screenshots

image

OS

Where does the bug occur?

EdualcLaiv commented 1 year ago

I forgot to point out that I tried to use the snippet without the whole theme and got same problems.

SlRvb commented 1 year ago

Should be fixed now with ITS v0.7.4 :)

Let me know if it worked!

EdualcLaiv commented 1 year ago

The theme is fixed! ๐Ÿ‘

But it seems you didn't updated the snippet : https://github.com/SlRvb/Obsidian--ITS-Theme/blob/main/Snippets/S%20-%20Callouts.css

Could you copy and paste your fix here as well? ๐Ÿ™

SlRvb commented 1 year ago

I've pushed the fix for the snippet as well now, do let me know if that works there as well :)

EdualcLaiv commented 1 year ago

It works fine with default theme now.

Thanks a bunch!

viluon commented 1 year ago

I think there are still glitches in the theme, shouldn't the timeline stretch between events? image

viluon commented 1 year ago

@EdualcLaiv did you experience the issue above?

EdualcLaiv commented 1 year ago

Nope. What's your exact markdown here?

viluon commented 1 year ago

@EdualcLaiv

> [!timeline|t-l t-3] **foo** _744 AI_

> [!timeline|t-r] **bar** _734 AI_

> [!timeline|t-l t-2] **oof** _702 AI_

renders as image