[FR] Apply dark theme to editor

SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.

https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme

GNU General Public License v2.0

523 stars 112 forks source link

[FR] Apply dark theme to editor #166

Closed Blackhawke closed 1 year ago

Blackhawke commented 1 year ago

I'm not sure why this is true, but in every theme I've looked at, even the "dark" ones, the editor has a light background, not the same, or similar dark background used in Preview.

For the rewrite, I'd like to see the ITS honor "dark mode" in the editor too. It's really blinding to go from the nice dark scheme to the blindingly light background and hard-to-read off-white text in the editor. I'm not suggesting the two be identical. That could create confusion. But similar would be nice.

SlRvb commented 1 year ago

I'm a bit confused, are you asking for a black background for darkmode?

Blackhawke commented 1 year ago

I'm asking for the editor to have a "dark mode" too. Or, at least a a dark background.

On Mon, Dec 19, 2022, 11:54 PM SlRvb @.***> wrote:

I'm a bit confused, are you asking for a black background for darkmode?

— Reply to this email directly, view it on GitHub https://github.com/SlRvb/Obsidian--ITS-Theme/issues/166#issuecomment-1358963857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANNFBOPRQ4ZD3XJMYCJZK3WOFQ37ANCNFSM6AAAAAATDW6QHY . You are receiving this because you authored the thread.Message ID: @.***>

SlRvb commented 1 year ago

The editor does have a darkmode 🤔. If yours doesn't, then something is very wrong on your end 🤔. If I could see a screenshot of your editor not having darkmode that would be very helpful as well as if you're using the legacy editor maybe? That should also have a darkmode background so not sure what could be going wrong there.

Blackhawke commented 1 year ago

Hmm...

Well, you may be right. I've noticed that there are a lot of plugins that won't even work on this tablet (Tab S6 Lite) and, I use it for a lot of art and the dev of the app I use says this particular tablet is a pain in the a$$ sometimes.

Anyway, I've attached a screenshot. If you can tell me, where are the controls to set dark mode in the editor? I've looked. I don't find them.

SlRvb commented 1 year ago

Oh gosh, that's pretty bad. Could you toggle on restricted mode and disable snippets to see if something might be going wrong there?

Blackhawke commented 1 year ago

Bingo! You nailed it. The CardView plugin was overriding the theme settings.

Thanks for your help!