SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
523 stars 112 forks source link

Links in checkboxes are not muted when checked out, but enhanced in bold #189

Closed PhilippeKr closed 1 year ago

PhilippeKr commented 1 year ago

Describe the bug

A clear and concise description of what the bug is.

Expected behavior I would expect the link to me muted, just like the rest of the text which changes colour.

To Reproduce

  1. Create a checkbox and put a link in the text.
  2. Check the checkbox
  3. See that the normal text is muted but that the link is bolded and in original bright colour

Screenshots

Screenshot 2023-04-04 203350

OS

Where does the bug occur?

Versions

SlRvb commented 1 year ago

Should be fixed in the beta now :)

PhilippeKr commented 1 year ago

Thanks. I've been looking at the beta on the site, but all the download links seem broken to me...

SlRvb commented 1 year ago

Ah could you look here again? I've update to reflect the new way to get the beta and its updates. https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme

PhilippeKr commented 1 year ago

Thanks, it works way better that way, easy to install and update. And yes, it's corrected in the sense that the links are no longer in bold when the checkbox is checked, I would however like and expect that they got dimmed a bit like the rest of the text. Would that be possible ? Or is it in an option that I have not found ? Thanks in advance (and thanks again for a great them). :D

SlRvb commented 1 year ago

They should be dimmed I made sure links, tags, etc were dimmed if a checkbox was checked. Could you screenshot the checked task so I can see what's going on?

It should look like this: Obsidian_CfxidscwlW

PhilippeKr commented 1 year ago

unnamed

Here you go, and thanks for looking into it. It might just be wrong configuration.

Philippe

On Mon, 17 Apr 2023 at 22:38, SlRvb @.***> wrote:

They should be dimmed I made sure links, tags, etc were dimmed if a checkbox was checked. Could you screenshot the checked task so I can see what's going on?

It should look like this: [image: Obsidian_CfxidscwlW] https://user-images.githubusercontent.com/54087190/232605251-9e178a6a-a029-4bb8-982b-9245304ab402.png

— Reply to this email directly, view it on GitHub https://github.com/SlRvb/Obsidian--ITS-Theme/issues/189#issuecomment-1512054931, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRRXCPB6N5AEAG7633TASLXBWS3PANCNFSM6AAAAAAWTCWCCU . You are receiving this because you authored the thread.Message ID: @.***>

SlRvb commented 1 year ago

I can't seem to recreate this issue, could you see if enabling restricted mode for plugins and disable all snippets. Just checking you have the beta theme installed via brat and not via snippets right?

PhilippeKr commented 1 year ago

Hi, apologies, I was on holidays, but I can confirm that the problem still occurs even with restricted mode and disabling all snippets, including ITS ones. And yes, the beta theme is installed by brat.

Thanks in advance,

Philippe

On Sun, 23 Apr 2023 at 22:44, SlRvb @.***> wrote:

I can't seem to recreate this issue, could you see if enabling restricted mode for plugins and disable all snippets. Just checking you have the beta theme installed via brat and not via snippets right?

— Reply to this email directly, view it on GitHub https://github.com/SlRvb/Obsidian--ITS-Theme/issues/189#issuecomment-1519152286, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRRXCOHQ2GQO33GENTGA2LXCWICDANCNFSM6AAAAAAWTCWCCU . You are receiving this because you authored the thread.Message ID: @.***>

SlRvb commented 1 year ago

Ah I think I fixed it, can you update the beta again?

PhilippeKr commented 1 year ago

It did not work, so I tried to uninstall the theme and install it again to make sure that I had the right version, but now it won't install: [image: image.png]

Also, I checked what happened with the theme uninstalled, and the color does not change, it's just that the text is crossed out when the checkbox is checked (which I find less interesting than a colour change).

Thanks in advance,

Philippe

On Mon, 8 May 2023 at 08:20, SlRvb @.***> wrote:

Ah I think I fixed it, can you update the beta again?

— Reply to this email directly, view it on GitHub https://github.com/SlRvb/Obsidian--ITS-Theme/issues/189#issuecomment-1537818210, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRRXCPWMX7M5K6R4XZC7B3XFCGCTANCNFSM6AAAAAAWTCWCCU . You are receiving this because you authored the thread.Message ID: @.***>

SlRvb commented 1 year ago

I'm not sure why it won't install (I also can't see the image), but you should just be able to run the command Update beta themes and that should get you the latest update.

Not sure how you uninstalled my theme, but it should just install fine with running that command with BRAT installed.

PhilippeKr commented 1 year ago

Thanks a lot for the continuous support. It did not work at first for no reason that I could discern, but it's perfect now, dimming the links as well as the text.

Thanks again, you're the best !

Philippe

On Tue, 9 May 2023 at 20:54, SlRvb @.***> wrote:

I'm not sure why it won't install (I also can't see the image), but you should just be able to run the command Update beta themes and that should get you the latest update.

Not sure how you uninstalled my theme, but it should just install fine with running that command with BRAT installed.

— Reply to this email directly, view it on GitHub https://github.com/SlRvb/Obsidian--ITS-Theme/issues/189#issuecomment-1540724688, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRRXCOBINTRCQYJBOM24F3XFKHHPANCNFSM6AAAAAAWTCWCCU . You are receiving this because you authored the thread.Message ID: @.***>