SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
555 stars 114 forks source link

[Bug] Link styling is lost when link includes markdown formatting #199

Closed Jnosh closed 1 year ago

Jnosh commented 1 year ago

Describe the bug

Markdown links that include markdown formatting in the link text loose the link styling in the current ITS beta:

[_Test **Link** Content_](https://obsidian.md)

Screenshots

Built-in theme:

Screenshot 2023-05-13 at 10 45 36

ITS beta:

Screenshot 2023-05-13 at 10 45 53

OS

Tested on macOS 13.4

Versions

SlRvb commented 1 year ago

The links with the markdown formatting do look correctly styled to me on my end 🤔 Obsidian_FSjiTKqzeZ

If you mean in comparison to the default theme, yeah I don't style my links like the default theme with an underline.

Jnosh commented 1 year ago

Yes, I just mean the link coloring difference in this case. I used the default theme just to compare whether obsidian by default retains the link styling when using bold or italics in the link text.

Here is a screenshot of two links, one with and one without formatting, using a new vault using ITS with default settings to better show the difference using just ITS:

Screenshot 2023-05-14 at 23 30 06

The link coloration is only missing in reading view, in editing view it is blue as usual.

Here is the sample vault with just ITS installed via BRAT and a note with those two links: Test.zip

Looking at the styling in the developer tools shows that the styling for em and strong is overriding the inherited styling for a.external-link, specifically the color. Seems in pre-1.0 ITS, --italic-color and --bold-color were set to inherit by default whereas in 1.0 they are set to --text.

SlRvb commented 1 year ago

Ah can you update to ITS v1.0.41 and see if this has been fixed?

Jnosh commented 1 year ago

👍 Working perfectly now!