SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
521 stars 113 forks source link

[Bug] Broken CSS classes #208

Closed Jnosh closed 1 year ago

Jnosh commented 1 year ago

Describe the bug

A couple of CSS classes that don't seem to be working anymore. Not sure if they were broken or removed with ITS 1.0 or broken by some Obsidian update but they are still listed in the documentation but don't seem to have any effect:

OS

Where does the bug occur?

Versions

SlRvb commented 1 year ago

All these classes should now be fixed in ITS v1.0.20. Only exception is alt-co and I meant to remove that one as that's now just the default callout styling so that should now be removed from the list on the guide.

Jnosh commented 1 year ago

readable, poem, hr-tog seem to be working correctly.

For writing, headings are centered and text is justified as mentioned in the documentation. For auto sets readable line width, that adjusts the line length when Readable line length is enabled, correct? If so, that seems to be working as well. Also, with the writing CSS class applied, some sort of visual indicator is added to links. Not sure if that is expected or a bug:

Screenshot 2023-05-30 at 14 44 53
SlRvb commented 1 year ago

In ITS v1.0.24 that link issue and the writing's line width should be fixed for when readable is off too

Jnosh commented 1 year ago

Perfect, thanks!