SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
521 stars 113 forks source link

[Bug] Minor visual issues with floating images/callouts and horizontal lines #212

Open Jnosh opened 1 year ago

Jnosh commented 1 year ago

Describe the bug

Two minor visual issues I noticed while documenting #207:

1) There is no padding/margin between a floating image and a horizontal line when the Note->Images->Clear Images->Horizontal Lines setting is activated. It would be nice if the image had the same margin/padding towards the line as for a non-floating image. Also affects floating callouts since they are also affected by Note->Images->Clear Images->Horizontal Lines. (Maybe the Clear Images settings should be move to the Horizonal Line and Headers setting sections instead as they affect both floating images and floating callouts)

Not floating, has nice distance from horizontal line:

Screenshot 2023-06-05 at 00 22 02

Floating image, content is larger than image height - content has a nice distance to horizontal line:

Screenshot 2023-06-05 at 00 25 53

Floating image where content next to image is shorter - image goes directly up to horizontal line with no margin or padding between:

Screenshot 2023-06-05 at 00 21 22

2) With default settings, where images can float next to horizontal lines, the horizontal line symbol can overlap with a wider image. I think the line symbol is always placed in the center of the page which then overlaps with a floating image if it is wider than 50% of the page width itself. The line symbol should ideally be placed in the center of the horizontal line so it adjusts position if the horizontal line is shortened due to some floating content. Again, this affect both images and callouts.

Screenshot 2023-06-05 at 00 28 55

OS

Versions