SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
553 stars 114 forks source link

Some style controls seem to not work #251

Closed Taliesin1 closed 8 months ago

Taliesin1 commented 11 months ago

Describe the bug

I set up a test Style Sheet note to test all the different controls for the different styles so I could learn what each of them do. Try as I might, I can't render any changes in this Style Sheet note — or any other note — on these controls:

Note>Text > Paragraph Spacing Note>Headers > Header Spacing Note>Lists/Bullet Adj>List Line Width Note>Lists/Bullet Adj>Original Bullet Lines

Expected behavior I would expect these controls to render visible changes to text with the applied style.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

If applicable, add screenshots to help explain your problem.

OS

Where does the bug occur?

Versions

Additional context

Add any other context about the problem here.

SlRvb commented 11 months ago

🤔 Hmm

Paragraph & Heading spacing work for me as well as Original Bullet Lines toggle, make sure you're in reading mode to see those changes though since they only really apply there.

List Line width slider also works but this one should work on either live preview or reading mode.

Taliesin1 commented 11 months ago

Ah, my bad — I musta been in live preview mode, because I switch to Reading mode now and I see that everything I listed before is working after all — with the exception of the List Line Width, which still apparently does nothing in either mode. Perhaps I don't understand what it's supposed to do? I expect the actual line width to get shorter, so that they're "indented" from the right and shorter than the body text line width. But when I turn that slider, the width of the list line doesn't change at all.

One other question — is there any chance we could get controls to alter the amount of space that follows a header? As it is now, the header floats midway between the paragraph that precedes it and the paragraph that follows it.

Headlines should always be closer to the paragraph below than the one above. Is there a way I can override this in the css? Not sure how the css I might write would be overridden by either the native styles or the ITS theme styles.

Thanks so much. This is an awesome theme!

SlRvb commented 11 months ago

Oooh, no the Line width meant the line for when a list has subbullets that's under the root bullet not the width of a bullet line 🤔 maybe I should call it something like list indentation width instead to clear that up?

If you open that request for header stuff as another issue so it's easier for me to track, I'll try to add it sometime soon :)

Taliesin1 commented 11 months ago

Ah, okay. I would suggest list indention weight, which is typically how designers think of the thickness of a line or rule. If there are other parameters that also deal with the thickness of the line, I'd change this to weight as well, for consistency.

I will enter another GitHub issue for my other request, sure thing. Thanks!