SlRvb / Obsidian--ITS-Theme

Theme designed with readability and customizability in mind. Change it easily to your liking with the Style Settings plugin installed.
https://publish.obsidian.md/slrvb-docs/ITS+Theme/ITS+Theme
GNU General Public License v2.0
553 stars 115 forks source link

[Bug] Image cannot be embedded in bullet list #317

Closed Missionary-OSBS closed 2 months ago

Missionary-OSBS commented 3 months ago

Describe the bug

Image cannot be embedded in bullet list, unless it's resized.

Expected behavior Image should be embedded in bullet list

To Reproduce

Steps to reproduce the behavior:

  1. Create a bullet list
  2. Embed an image on the bullet list without resizing it
  3. See error: the image cannot be embedded

Screenshots

ITS theme 2024-06-21_15 26 24_CSX|400

Default theme 2024-06-21_15 26 41_CSX

However, if I resize the image, it works fine. In this example, I resize down to |400 2024-06-21_15 27 16_CSX|400

OS

Where does the bug occur?

Versions

SlRvb commented 3 months ago

Hmmm I can't seem to replicate this issue, not sure if this is also related to the #282 issue that I also can't seem to replicate 🤔

Missionary-OSBS commented 3 months ago

I think I know what happened. When the editor window is narrow, the image cannot be rendered. But when I close all the sidebars and the editor window gets wider, the image now can be rendered.

Narrow editor window (I use this all the time, taking note on the right side of the screen, while watching the content on the left side) 2024-06-24_22 01 26_CSX

Wide editor window (fullscreen mode) 2024-06-24_22 02 44_CSX

SlRvb commented 3 months ago

Hmmm, even with installing the plugin I might've thought would be conflicting I still can't recreate this. Do you happen to have the image I could test this on or at least what size the image is so I can try to replicate this?

Missionary-OSBS commented 3 months ago

Sure, here is the link: https://www.playbook.com/s/missionary/fZj9hx5N9Q8MQvbYXm3TSPTY?assetToken=B4JKMYBug2UJJ6TNpcCoE5LE

Are you sure you tried it on a bullet list - ![[image]] ? 2024-06-25_15 33 44_CSX

SlRvb commented 3 months ago

oh this looks like funky conflicts between the Justify Text setting and just huge images being pushed super far to the right 🤔

SlRvb commented 3 months ago

Okay yeah, that's exactly what's happening. Now I can definitely recreate this, will see what I can do about it

SlRvb commented 2 months ago

Should be fixed in ITS v1.2.88!