Closed MLRichmond closed 2 years ago
After a bit more review, I'm not sure this is related to any recent change. I tried going back several revisions and it is broken in all of them.
If you click on the very, very edge of the row, you can still expand and collapse the row. This leads me to believe that there is something from the theme that is sitting on top of the clickable element from AidenLx's Folder Note and obstructing it.
Ok - I've identified the issue.
.nav-folder-title-content,
.nav-file-title-content {
width: 100%;
line-height: 20px;
}
The width 100% used to move file extensions to the end (looks nice, btw) causes the row to be width 100%, which obstructs the clickable element from Aiden's.
Double check me but I think the fix is as simple as this:
/*Move File Extension to Right*/
.nav-file-title-content {
width: 100%;
line-height: 20px;
}
body:not(.type-undo) .nav-file-title {
flex-direction: row-reverse;
}
/* Nav folder line height */
.nav-folder-title-content{
line-height: 20px;
}
Oooh, now that's interesting. I'll load up that folder note plugin and see what I can do to fix it right off the bat since it seems like a lot of new ttrpg folks are coming around and it's not quite obvious what the fix is.
For some, I've mentioned that the Style Settings toggle: Display The Folder Arrow On Hover
under Workspace
should fix being unable to open/close the folder. Does that work for you?
Okay, I've added the ability to auto display the folder arrow when hovering over the folder that has a folder note in it in the new commit: 981508a
The fix does work - but rendering the arrow on hover causes some pop-in with the row. The fix I proposed allows you to click the row anywhere outside of the text to expand/collapse which is how it works in other themes.
This is usable, but I prefer the other personally. Does the width change cause issues elsewhere that I didn't notice?
Hmm, fair enough. That is definitely nicer visually and in terms of usability. I've added that to the newest commit so it should work now. 👀
Works great! Thank you!
The latest update to the theme is incompatible with AidenLx's Folder Note.
Top level folders still function correctly, but sub-folders no longer expand or contract in the explorer view.
Deactivating AidenLx's or switching to another theme both resolve the issue.